More phpcbs code cleanups #22551
Merged
More phpcbs code cleanups #22551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
totten
reviewed
Jan 18, 2022
install/langs.php
Outdated
| @@ -1,4 +1,4 @@ | |||
| <?php $langs = array ( | |||
| <?php $langs = [ | |||
There was a problem hiding this comment.
This file is generated via CRM/Core/CodeGen/I18n.php:
file_put_contents('../install/langs.php', "<?php \$langs = " . var_export($langs, TRUE) . ";");There was a problem hiding this comment.
A newline would be nice after the <?php at least
There was a problem hiding this comment.
I've removed it from the PR
a5dacf4 to
28a98d7
Compare
| ); |
There was a problem hiding this comment.
this might come back but it's hard to remove too since I have to beat up my editor to not do this - I think we can ignore this accidental extra fix
|
Patch looks good. |
|
thanks @monishdeb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.