-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some old scripts #22534
Remove some old scripts #22534
Conversation
(Standard links)
|
set-version is definitely used unsure about the others |
Yeah, we definitely use Agree with all the removals in the current PR. Can't find any evidence of them being used by This folder is a kind of random grab-bag -- I think everyone who looks at it says, "I don't know what these are for." Skimming these... here are a few that I'd straight-up vote for removal:
These might merit a little more thought:
|
I definitely think the postIPN.sh should go - it is the wrong url for starters and really doesn't add anything I can see to our other ways of testing IPNs |
I history on the ckeditor one suggests it is used - I put up PRs for the others |
Overview
Scripts in tools directory don't actually ship - the only reason for them is if we use them in the release process I think...
Before
These scripts seem very unlikely to be used to me
NormalizePhone
soapClient
testProcess
test_sandbox
After
Listed ones removed
This handful still exists - do we use them?
Technical Details
@seamuslee001 unless you or @totten use these - or the remaining ones - I'd be pretty sure they are not used.
We seem to occassionally have updated them but only for style & security reasons (it was style issues that popped them onto my radar today)
Comments