Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ref] Remove unused _colours property #22525

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

braders
Copy link
Contributor

@braders braders commented Jan 16, 2022

Overview

[Ref] Remove unused _colours property.

Comments

Multiple factors make me think this property is unused.

  • Searching the codebase for _colours returns no other options,
  • The commit which introduced the array contains the phrase "WIP" (work in progress),
  • The property is marked as private, and so I don't think there is a risk of this breaking extensions.

@civibot
Copy link

civibot bot commented Jan 16, 2022

(Standard links)

@civibot civibot bot added the master label Jan 16, 2022
@colemanw colemanw merged commit 1efd2a0 into civicrm:master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants