Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move deprecated function back to the only class that calls it #22517

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

This function is only called from the importer (in core) - copy back there & noisily
deprecate (one known extension usage).

Note that I removed 2 parts of it in the copy back that are unreachable
as only specific params are passed in we know they don't include
case & always include skipRecent

$relationParams = [];
$relationParams = [
'relationship_type_id' => $key,
'contact_check' => [
$relContactId => 1,
],
'is_active' => 1,
'skipRecentView' => TRUE,

@civibot
Copy link

civibot bot commented Jan 15, 2022

(Standard links)

@civibot civibot bot added the master label Jan 15, 2022
This function is only called from the importer (in core) - copy back there & noisily
deprecate (one known extension usage).

Note that I removed 2 parts of it in the copy back that are unreachable
as only specific params are passed in we know they don't include
case & always include skipRecent

https://github.com/civicrm/civicrm-core/blob/5484728757de4c85d44305a92bfa2aa35351fbce/CRM/Contact/Import/Parser/Contact.php#L880-L887
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 can I get a merge on this too - there are tests that go through it

@seamuslee001
Copy link
Contributor

This seems fine to me

@seamuslee001 seamuslee001 merged commit 58de109 into civicrm:master Jan 16, 2022
@seamuslee001 seamuslee001 deleted the skip branch January 16, 2022 23:13
@eileenmcnaughton
Copy link
Contributor Author

thanks @seamuslee001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants