Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(REF) ContactUtils - Rename local variables #22510

Merged
merged 1 commit into from
Jan 14, 2022
Merged

(REF) ContactUtils - Rename local variables #22510

merged 1 commit into from
Jan 14, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Rename variables

Before

$organization
$relTypeId
$previousEmpId

After

$employerID
$relationshipTypeID
$previousEmployerID

Technical Details

IDE rename - organization is an ID not a string - which was the main motive

Comments

@civibot
Copy link

civibot bot commented Jan 14, 2022

(Standard links)

@civibot civibot bot added the master label Jan 14, 2022
@totten totten changed the title Rename variables (REF) ContactUtils - Rename local variables Jan 14, 2022
@totten totten merged commit b8e1699 into civicrm:master Jan 14, 2022
@eileenmcnaughton eileenmcnaughton deleted the legacy2 branch January 15, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @totten