Move permission checks from Query & BAO to financialacl extension

[eileenmcnaughton]

Overview

Move permission checks from Query & BAO to financialacl extension

I'll rebased this once the MOP one is merged

Before

Core code doing financial acl checks in Contribution_BAO & BAO_Query

After

Moved to the extension

Technical Details

I don't think we need to early return for the other financial reports extensions - I don't there there would be performance impact if we got an extra WHERE financial_type_id IN (1,2) - it was mostly just a transitional thing I think

Comments

Anything else you would like the reviewer to note

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Ok, cleanup makes sense.