Add unit test on updateGreeting & remove deprecated fn call #22482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to tokenDetails loads the contact details and they are passed along - however if not loaded here they will be loaded later so there is no gain & it calls a deprecated function
|
(Standard links)
|
| @@ -1034,17 +1034,12 @@ public static function updateGreeting($params) { | |||
| } | |||
|
|
|||
| if (empty($filterContactFldIds)) { | |||
| $greetingDetails = []; | |||
There was a problem hiding this comment.
if greetingDetails & filterContactFldIds are empty it is the same as returning as the following code is only invoked if they are not empty
|
@seamuslee001 can I get a merge on this - we didn't remove it last round because of the lack of test but ..... tada |
|
seem fines to me |
|
thanks @seamuslee001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add unit test on updateGreeting & remove deprecated fn call
Before
The call to tokenDetails loads the contact details and they are passed along - however
if not loaded here they will be loaded later so there is no gain & it
calls a deprecated function
After
poof
Technical Details
Comments