Revert membership debug handling in IPN #22475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A looong time ago we added handling for the possibility of messed up memberships going through the paypal IPN. civicrm#15053 At the time we added a lot of debug to see if it was ever hit as the handling was an attempt to figure out a bug that we couldn't reproduce. We never got any evidence the debug was hit or the fix helped - but it does create a lot of code complexity and makes clean up more difficult so this removes it again....
|
(Standard links)
|
|
@MegaphoneJon are you able to endorse this one - it was you trying to track down an error that led to this being added I think - but it never seemed to do much good in the end |
|
This is fine with me to go. |
|
@seamuslee001 @colemanw could one of you merge? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Revert membership debug handling in IPN
A looong time ago we added handling for the possibility of messed up memberships going through
the paypal IPN. #15053
At the time we added a lot of debug to see if it was ever hit as the handling was
an attempt to figure out a bug that we couldn't reproduce. We never got any
evidence the debug was hit or the fix helped - but
it does create a lot of code complexity and makes clean up
more difficult so
this removes it again....
Before
Lotsa code that was there to try to find an error that turned out to have been elsewhere
After
poof
Technical Details
Comments