Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken function reference #22474

Merged

Conversation

braders
Copy link
Contributor

@braders braders commented Jan 11, 2022

Overview

Fix broken function reference. (no method formatMailUnrecognisedPart exists)

Before

It appears the names of function created and subsequently used in 4315599 didn't match. Therefore broken PHP.

After

Working PHP.

@civibot
Copy link

civibot bot commented Jan 11, 2022

(Standard links)

@civibot civibot bot added the master label Jan 11, 2022
@colemanw
Copy link
Member

@braders thanks for this. Just one issue, the stylechecker says "Expected newline after closing brace"

@braders
Copy link
Contributor Author

braders commented Jan 11, 2022

@braders thanks for this. Just one issue, the stylechecker says "Expected newline after closing brace"

Does the stylechecker only check files you've changed? Because I've not changed any whitespace here...

@colemanw
Copy link
Member

Yes. I guess the file was problematic before you made the change. It says the missing line is on L455.

@braders braders force-pushed the incoming-mail-broken-fn-reference branch from 4520c86 to a71c815 Compare January 11, 2022 18:35
@colemanw
Copy link
Member

Thanks that fixed it

@colemanw
Copy link
Member

Aside, IMO forcing a newline between if and else is not a very nice part of the Drupal coding standards.

@eileenmcnaughton eileenmcnaughton merged commit d2e6699 into civicrm:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants