Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split mailing label formatting out from main format #22463

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Splitting these 2 functions out allows cleanup & eventual decommissioning of the mailing label
function.

There are siginificant usage differences depending on context so this will permit
cleanup - I did a universe search & these are the only 2 times it is called with
mailing = TRUE

Before

One big toxic function does a whole lotta stuff

After

We've started the separation & cleanup

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jan 10, 2022

(Standard links)

Splitting these 2 functions out allows cleanup & eventual decommissioning of the mailing label
function.

There are siginificant usage differences depending on context so this will permit
cleanup - I did a universe search & these are the only 2 times it is called with
mailing = TRUE
@mattwire mattwire merged commit 66bb837 into civicrm:master Mar 9, 2022
@eileenmcnaughton eileenmcnaughton deleted the label branch March 10, 2022 01:59
@eileenmcnaughton
Copy link
Contributor Author

Thanks @mattwire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants