Split mailing label formatting out from main format #22463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Splitting these 2 functions out allows cleanup & eventual decommissioning of the mailing label
function.
There are siginificant usage differences depending on context so this will permit
cleanup - I did a universe search & these are the only 2 times it is called with
mailing = TRUE
Before
One big toxic function does a whole lotta stuff
After
We've started the separation & cleanup
Technical Details
Comments