Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark function as private #22457

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Mark function as private #22457

merged 1 commit into from
Jan 10, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Mark function as private

Before

You need to do a universe search (like I did) to see that the function is not called from elsewhere

After

It's private

Technical Details

I did a universe search & this is not called outside this class (the
one on the LabelCommon class is called from one place outside that class

Comments

I did a universe search & this is not called outside this class (the
one on the LabelCommon class is called from one place outside that class
@civibot
Copy link

civibot bot commented Jan 10, 2022

(Standard links)

@civibot civibot bot added the master label Jan 10, 2022
@colemanw colemanw merged commit 9cc3d84 into civicrm:master Jan 10, 2022
@eileenmcnaughton eileenmcnaughton deleted the label branch January 10, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants