Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty check #22444

Merged
merged 1 commit into from
Jan 16, 2022
Merged

Remove empty check #22444

merged 1 commit into from
Jan 16, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

We had to ensure this was always assigned for default modifier so remove the
empty to make it clear it is 'sorted'

@civibot
Copy link

civibot bot commented Jan 10, 2022

(Standard links)

@civibot civibot bot added the master label Jan 10, 2022
@eileenmcnaughton
Copy link
Contributor Author

test this please

1 similar comment
@eileenmcnaughton
Copy link
Contributor Author

test this please

demeritcowboy
demeritcowboy reviewed Jan 16, 2022
View reviewed changes
templates/CRM/common/snippet.tpl Outdated
@@ -34,7 +34,7 @@
{include file="CRM/common/status.tpl"}
{/if}

{if !empty($isForm)}
{if !$isForm}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems backwards.
It kind of scares me that it passes tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@demeritcowboy you are totally right - it was wrong - fixed now

@eileenmcnaughton
Remove empty check
8e71679 
We had to ensure this was always assigned for default modifier so remove the
empty to make it clear it is 'sorted'
@eileenmcnaughton
Copy link
Contributor Author

unrelated fail

@eileenmcnaughton eileenmcnaughton merged commit 5519b41 into civicrm:master Jan 16, 2022
@eileenmcnaughton eileenmcnaughton deleted the isform branch January 16, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demeritcowboy demeritcowboy demeritcowboy left review comments

Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @demeritcowboy