Navigation - Make required fields NOT NULL #22430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Cleans up
civicrm_navigation
to make required fields NOT NULL.Before
Fields
weight
andis_active
can ambiguously be 0 or NULL, which effectively means the same thing.After
Now they will always have a value.
Comments
IMO we should do this for every
weight
andis_active
field in the DB, but I'm starting with this one entity to see how it goes.