Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation - Make required fields NOT NULL #22430

Merged
merged 1 commit into from
Jan 9, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jan 9, 2022

Overview

Cleans up civicrm_navigation to make required fields NOT NULL.

Before

Fields weight and is_active can ambiguously be 0 or NULL, which effectively means the same thing.

After

Now they will always have a value.

Comments

IMO we should do this for every weight and is_active field in the DB, but I'm starting with this one entity to see how it goes.

@civibot
Copy link

civibot bot commented Jan 9, 2022

(Standard links)

@civibot civibot bot added the master label Jan 9, 2022
@colemanw
Copy link
Member Author

colemanw commented Jan 9, 2022

retest this please

@eileenmcnaughton
Copy link
Contributor

I agree with this change & the general principle that boolean fields should all be required & have a default. I think it makes sense for weight too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants