[REF] Centralize BAO handling of custom data

[colemanw]

Overview

Refactors the BAO to handle custom data from a central writeRecords function, and updates APIv3 accordingly.

Technical Details

• Refactors a couple BAOs which use writeRecord, as they no longer need to write the custom data themselves.
• Stops APIv3 passing the deprecated $ids param to BAO::create
• Switches APIv3 to use BAO::writeRecord when BAO::create or BAO::add are @deprecated
• In APIv3, trust BAO::writeRecord to handle custom data

Comments

The possible breaking change here is not passing the long-deprecated $ids from APIv3 to BAO::create/add functions, but I note that APIv4 calls those same functions without passing the param and works fine.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Test Result (1 failure / -1)api_v3_NavigationTest.testDefaultDomain with data set "APIv3"

[eileenmcnaughton]

This looks good and we have tonnes of test cover - so if we can get the tests to pass I think it's good to go

[colemanw]

@eileenmcnaughton was that a MOP? I just added some api_defaults to the v3 Navigation to fix the test.

[eileenmcnaughton]

@colemanw yep - I think this is good - we have heaps of crud testing on apiv3 - it does mean that we can start deprecating bao crud functions with a view to eventual removal