Replace all isset checks on line.tax_rate

[eileenmcnaughton]

Overview

Replace all isset checks on line.tax_rate

Before

isset checks fail when smarty default modifier is on - the value is always set

civicrm-core/CRM/Price/BAO/LineItem.php

Lines 246 to 253 in 64f4eeb

	if (isset($lineItems[$dao->id]['financial_type_id']) && array_key_exists($lineItems[$dao->id]['financial_type_id'], $taxRates)) {
	// Cast to float so trailing zero decimals are removed for display.
	$lineItems[$dao->id]['tax_rate'] = (float) $taxRates[$lineItems[$dao->id]['financial_type_id']];
	}
	else {
	// There is no Tax Rate associated with this Financial Type
	$lineItems[$dao->id]['tax_rate'] = FALSE;
	}

• although tests might reveal a flow in which that is not true....

After

Simple check for truthy - it should be a float or FALSE

Technical Details

I'm not planning on doing any upgrade change for this - for most sites it is an immaterial difference so better to wait until a material change comes along

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).