Increase GroupContact:create deprecation #22416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note the v3 api does not call this & no-where in core calls it directly.
|
(Standard links)
|
|
Ok looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Increase GroupContact:create deprecation
Before
Code exists that was noisily deprecated in Aug 2020
After
That bit of code removed - noisy deprecation added to the top of the function, params removed
Technical Details
Note the v3 api does not call this & no-where in core calls it directly - and it has never been supported to call it from outside of core due to a supported api method existing
Comments
@colemanw - I'm digging into this BAO - but I think the create method warrants a bit more aggressive treatment (per this PR) - I'm about to switch to the add & will do some testing on that part (this will create some minor conflicts in your PR but should be pretty manageable)