Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for contact_check as it is always an array here #22407

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove check for contact_check as it is always an array here

Before

contact_check is always set & always an array in this function as it is only called from one place - that sets an array

image

dataExists just checks that it IS an array AND it is only called from one place

After

dataExists call removed and as it is the last call it is deprecated

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jan 7, 2022

(Standard links)

@civibot civibot bot added the master label Jan 7, 2022
@colemanw colemanw merged commit d04500f into civicrm:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants