[REF] Stop returning unused variables #22401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
5683006 to
a8f5f2c
Compare
eileenmcnaughton
commented
Jan 7, 2022
| @@ -146,82 +146,6 @@ public function testRelationshipTypeAddStudentSponcor() { | |||
| $this->relationshipTypeDelete($result->id); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Remove tests that cover unused functionality
Only 2 code places call this function (one an unsupported call outside core but in universe & the other in Parser_Contact) and only the latter uses ANY of the return variables - this fixes the function to stop returning those that are never used - this stops them from returning them
a8f5f2c to
c64f77c
Compare
|
@colemanw can we merge this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Only 2 code places call this function (one an unsupported call outside core but in universe & the other in Parser_Contact)
and only the latter uses ANY of the return variables - this fixes the function to stop
returning those that are never used - this stops them from returning them
Before
Only the first & third return values are used from the 2 places that call the function
Core usage in Parser_Contact
Unsupported extension usage
After
Only the used values are returned
Technical Details
@seamuslee001 this won't break the jma grantapplications extension as you can see from the above screenshot (and none of my patches do as yet) - but the functions was deprecated in 4.6 so really the extension should call the api.... is it still used?
Comments