dev/core#3001 escape single quotes when rendering tokens in html format #22387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Added the corresponding unit-test and update for the release-notes. Merge on pass. |
eileenmcnaughton
commented
Jan 6, 2022
| @@ -132,6 +132,21 @@ public function getDateFormats(): array { | |||
| ]; | |||
| } | |||
|
|
|||
| public function testTokenDataEscape() { | |||
There was a problem hiding this comment.
Ug - now you've ported it I'm gonna have to fix up the style issues
There was a problem hiding this comment.
(the reason I didn't port originally)
There was a problem hiding this comment.
Done - looks like the tests had only been running for 20 mins so ...
|
jenkins, test this please |
|
All green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port fix from #22285