Fix campaign dashboard to work with default escaping #22364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix campaign dashboard to work with default escaping
Before
After
Technical Details
I just added the general escape by-pass - but I notice they are json encoded - I wonder if there is something more clever to consider
In general we want the decision not to escape to be active (which this approach achieves) - however there is a low level risk it could be a good decision at the time it's added & become compromised over time. (This is probably fine for now as we are raising the bar by making default escaping work at all & this is at least greppable)
Comments