Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix campaign dashboard to work with default escaping #22364

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jan 3, 2022

Overview

Fix campaign dashboard to work with default escaping

Before

After

Technical Details

I just added the general escape by-pass - but I notice they are json encoded - I wonder if there is something more clever to consider

image

In general we want the decision not to escape to be active (which this approach achieves) - however there is a low level risk it could be a good decision at the time it's added & become compromised over time. (This is probably fine for now as we are raising the bar by making default escaping work at all & this is at least greppable)

Comments

@civibot
Copy link

civibot bot commented Jan 3, 2022

(Standard links)

@civibot civibot bot added the master label Jan 3, 2022
@colemanw
Copy link
Member

colemanw commented Jan 4, 2022

Oh boy another merge-conflict for #22064

@colemanw colemanw merged commit 0f0cf10 into civicrm:master Jan 4, 2022
@colemanw colemanw deleted the defaults branch January 4, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants