-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add state name to export fields #22318
Conversation
(Standard links)
|
CRM/Core/BAO/Mapping.php
Outdated
if (!empty($fields[$contactType]['state_province']) && empty($fields[$contactType]['state_province_name'])) { | ||
$fields[$contactType]['state_province_name'] = $fields[$contactType]['state_province']; | ||
$fields[$contactType]['state_province_name']['title'] = 'State Name'; | ||
$fields[$contactType]['state_province']['title'] = 'State Abbreviation'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should'ts' be used on the titles?
Also if possible can you use 'State/Province' instead of just 'State'? I know it was previously like that, but it would be more consistent with the rest of CiviCRM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jitendrapurohit ready to merge after incorporating @mlutfy 's feedback for translated strings. |
85709d1
to
e58cbdf
Compare
Test fails seem unrelated: c.f. #22352
|
jenkins, test this please |
1 similar comment
jenkins, test this please |
@jitendrapurohit looks good, merging this. You might want to make sure the column name is displayed as State/Province Name instead of state_province_name. |
Overview
Add state name to export fields
Before
Export Contact only has a State field which render as state abbreviation. There is no way to export the name of the state in core.
To replicate:
Choose fields to export
.After
New field added to export state name.
Comments
Related GitLab - https://lab.civicrm.org/dev/core/-/issues/724. Probably we should also add
state_province_name
to the default return properties so its also available on the primary field export?