Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap another set of hardcoded strings in {ts} #22315

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

braders
Copy link
Contributor

@braders braders commented Dec 23, 2021

Overview

Does what it says on the tin.

Before

Hardcoded strings

After

{ts}{/ts}/ ts() used

@civibot
Copy link

civibot bot commented Dec 23, 2021

(Standard links)

@civibot civibot bot added the master label Dec 23, 2021
@braders braders force-pushed the more-hardcoded-strings-2 branch from 4f81c5d to 9d4c648 Compare December 23, 2021 18:25
@mlutfy
Copy link
Member

mlutfy commented Dec 23, 2021

Thanks @braders - this kind of fixing is much appreciated!

I reviewed most of the code, but need to do a quick r-run for the places where the string is used in panes (probably fine, but can't tell only from the diff).

@braders braders force-pushed the more-hardcoded-strings-2 branch from 9d4c648 to c995124 Compare December 24, 2021 13:05
@yashodha
Copy link
Contributor

@braders looks good, merging this.

@yashodha yashodha merged commit 6a18c2f into civicrm:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants