Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of .font-size11pt and .font-size12pt #22314

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

braders
Copy link
Contributor

@braders braders commented Dec 23, 2021

Overview

https://lab.civicrm.org/dev/core/-/issues/3004

civicrm.css contains the following CSS:

.crm-container .font-size11pt {
  font-size: 1.1em;
}

.crm-container .font-size12pt {
  font-size: 1.2em;
}

These are used, but rarely and inconsistently, throughout the CiviCRM codebase. I see the following issues with these classes:

  • These classes are used inconsistently, and I can't imendiately see what the rules are that decided their use.
  • When these classes are used, just the font-size is adjusted, which can lead to the area around that label appearing cramped.
  • Using font-size alone to pull attention to a label is fairly lazy design, and can look like a UI mistake rather than a feature.
  • These classes are treated inconsistently in different CiviCRM themes.
  • These class names are not semantic, and also are not strictly accurate given we're using em not pt.

Having looked through the Git hsitory there is only one occurance of someone having used one of these classes since the migration from SVN 9 years ago. Therefore, removing.

@civibot
Copy link

civibot bot commented Dec 23, 2021

(Standard links)

@civibot civibot bot added the master label Dec 23, 2021
@braders braders force-pushed the core-3004-remove-fontsize-classes branch from 551b9aa to 4d98365 Compare December 23, 2021 15:55
@mlutfy
Copy link
Member

mlutfy commented Dec 23, 2021

jenkins, test this please

@jaapjansma
Copy link
Contributor

@BettyDolfing and I are reviewing PRs and we came across this one.

@braders this PR has merge conflicts are you able to resolve them?

@braders braders force-pushed the core-3004-remove-fontsize-classes branch from 4d98365 to 2966927 Compare January 24, 2022 19:27
@braders
Copy link
Contributor Author

braders commented Jan 24, 2022

@jaapjansma Not sure why this was showing as having conflicts as I didn't see them locally. But a quick rebase against master seems to have resolved it.

@colemanw colemanw merged commit 3cecad6 into civicrm:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants