[REF] Extract & stdise AmountBlockIsActive #22291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -487,8 +487,7 @@ public function buildQuickForm() { | |||
| $this->buildCustom($this->_values['honoree_profile_id'], 'honoreeProfileFields', TRUE, 'honor', $fieldTypes); | |||
| } | |||
| $this->assign('receiptFromEmail', $this->_values['receipt_from_email'] ?? NULL); | |||
| $amount_block_is_active = $this->get('amount_block_is_active'); | |||
There was a problem hiding this comment.
set in preProcess - but preProcess also ensure the _values value is set so why have 2 ways?
| } | ||
| // This can probably go as nothing it 'getting it' anymore since the values data is loaded | ||
| // on every form, rather than being passed from form to form. | ||
| $this->set('amount_block_is_active', $this->isFormSupportsNonMembershipContributions()); |
There was a problem hiding this comment.
I was in 2 minds on commenting vs removing
01a312c to
494015b
Compare
| @@ -365,7 +365,6 @@ public function preProcess() { | |||
|
|
|||
| // this avoids getting E_NOTICE errors in php | |||
| $setNullFields = [ | |||
| 'amount_block_is_active', | |||
There was a problem hiding this comment.
Since the function to interact with this handles the possibility of it not being set we don't need this enotice prevention
494015b to
5b613e7
Compare
It took me a bit to figure out what it even meant - so extracted into a function which can provide explanation. Part of trying to stop passing known values around - see pass to isSeparateMembershipTransaction - that function should require no input params & be callable with consistent results anywhere
5b613e7 to
1bec3b5
Compare
|
thanks @mattwire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Extract & stdise AmountBlockIsActive
Before
The amount_block_is_active value is a bit of a mystery. I had to deep dive to figure out what it meant.
After
The value is accessed from a more descriptive function and the comment block provides more detail
Technical Details
Part of trying to stop passing known values around and rather retrieve them via functions - eg pass to isSeparateMembershipTransaction
Comments