Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomGroup - Add pseudoconstant for extends column #22282

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

colemanw
Copy link
Member

Overview

Adds missing pseudoconstant to schema, which will allow a SearchKit-based display of custom groups.

Technical Details

I'm not sure if there's a reason for this to be missing, but if tests pass then it's probably OK.

Comments

Toward https://lab.civicrm.org/dev/user-interface/-/issues/44#note_68136

@civibot
Copy link

civibot bot commented Dec 20, 2021

(Standard links)

@civibot civibot bot added the master label Dec 20, 2021
@colemanw
Copy link
Member Author

@seamuslee001 it was basically a typo in the test. All passing now.

@eileenmcnaughton eileenmcnaughton merged commit 31d176f into civicrm:master Dec 20, 2021
@eileenmcnaughton eileenmcnaughton deleted the cgExtends branch December 20, 2021 19:57
@KarinG
Copy link
Contributor

KarinG commented Dec 21, 2021

This PR caused all our WFC tests to fail -> RC is fine

image

image

colemanw added a commit to colemanw/civicrm-core that referenced this pull request Dec 22, 2021
Strings do not need to be strictly matched to pseudoconstants
during get operations.

Fixes regression caused by civicrm#22282.
@colemanw
Copy link
Member Author

@KarinG I'm hoping this will fix it: #22298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants