[REF] Duplicate & unshare processFormContribution #22276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only way I've managed to break up these big toxic functions is divide & conquer. While it seems counter-intuitive to not doing things in more than one place in practice much of the code is form-relevant and the the code before, during and after these functions does a whole lot of extra work to share stuff that they don't really have in common. This dates back pre-api when the only copy of the business logic often was on the forms....
|
(Standard links)
|
| @@ -1043,7 +1046,7 @@ protected function postProcessPremium($premiumParams, $contribution) { | |||
| * @throws \CRM_Core_Exception | |||
| * @throws \CiviCRM_API3_Exception | |||
| */ | |||
| public static function processFormContribution( | |||
| protected static function processFormContribution( | |||
There was a problem hiding this comment.
Obviously it's not supported to call this from outside core - but I did do a universe search to double check
|
Yay, more crappy code. Thanks @eileenmcnaughton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Duplicate & unshare processFormContribution
Before
Code shared between front end & back office forms - but not in a way that reduces the total amount of code
After
Code duplicated & unshared - allowing further cleanup
Technical Details
The only way I've managed to break up these big toxic functions is divide & conquer. While it seems
counter-intuitive to not doing things in more than one place in practice much of the
code is form-relevant and the the code before, during and after these functions
does a whole lot of extra work to share stuff that they don't really have in common.
This dates back pre-api when the only copy of the business logic often was on the forms....
Comments