Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds the test shell for https://lab.civicrm.org/dev/core/-/issues/567 which has previously been blocked on needing a test.
I looked at #22100 and thought to direct to where the test would go & then realised the test would be easy to write. However, I've left is as not actually testing - just providing clues. When I dug into the code that would need changing I realised I wasn't comfortable making the proposed change without some cleanup prior to making the change. I will separately put up a PR to un-share the
processFormContribution
function as the shared nature of that function is a major contributor to the problems with it.Before
Hard for people to know where to add tests
After
Shell test exists - will add to the issue
Technical Details
Comments