Fix Fatal Error on contribution tab and user dashboard when recurring payment generated using extension get disabled

[sunilpawar]

Overview

Step to reproduce:

1. Install extensions which support recurring payment e.g Stripe.
2. Create Recurring payment using that processor. (maybe use API Explorer to create it)
3. Disable extension.
4. Visit the Contribution tab or user Dashboard screen. you will get a fatal error.

Before

Fatal Error were showing

After

It shows a recurring record with VIEW link.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@sunilpawar it should be the case that we load the pseudoprocessor (CRM_Core_Manual - id = 0) when there is not 'real' processor. Not sure why that isn't happening but I think it should

[sunilpawar]

@eileenmcnaughton in our case we are getting processor id, so its not 0.

$paymentProcessorObj = Civi\Payment\System::singleton()->getById(CRM_Contribute_BAO_ContributionRecur::getPaymentProcessorID($recurID));

function getPaymentProcessorID it just return id associated with recurring record.

as you suggested, i am checking like this, i don't know is it right way and place to add CRM_Core_Payment_Manual object in function getByProcessor, because getByProcessor is used at multiple places.

diff --git a/Civi/Payment/System.php b/Civi/Payment/System.php
index 358ce7f023..6c66c1c68d 100644
--- a/Civi/Payment/System.php
+++ b/Civi/Payment/System.php
@@ -65,6 +65,9 @@ class System {
           $processorObject->setPaymentProcessor($processor);
         }
       }
+      else {
+        return new \CRM_Core_Payment_Manual();
+      }
       $this->cache[$id] = $processorObject;
     }

[eileenmcnaughton]

@sunilpawar I re-read this & I guess it doesn't make sense to return any links if there is no enabled processor - so explictly doing that makes sense on thinking about it - merging