Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Test cleanup #22251

Merged
merged 1 commit into from
Dec 15, 2021
Merged

[NFC] Test cleanup #22251

merged 1 commit into from
Dec 15, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[NFC] Test cleanup

Before

After

Technical Details

This biggest part of this is relying on the tearDown to do the cleanup more. This is the right
way because if the test fails the cleanup won't happen if it is in the test itsef

Comments

@civibot
Copy link

civibot bot commented Dec 14, 2021

(Standard links)

@civibot civibot bot added the master label Dec 14, 2021
@seamuslee001
Copy link
Contributor

@eileenmcnaughton style issue https://test.civicrm.org/job/CiviCRM-Core-PR/45869/checkstyle/

@eileenmcnaughton
[NFC] Test cleanup
e211492 
This biggest part of this is relying on the tearDown to do the cleanup more. This is the right
way because if the test fails the cleanup won't happen if it is in the test itsef
@demeritcowboy demeritcowboy merged commit 9c1644b into civicrm:master Dec 15, 2021
@eileenmcnaughton eileenmcnaughton deleted the rel3 branch December 15, 2021 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @seamuslee001 @demeritcowboy