Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2977 - For custom group creation, flip the default display settings #22244

Merged
merged 1 commit into from
Dec 14, 2021
Merged

dev/core#2977 - For custom group creation, flip the default display settings #22244

merged 1 commit into from
Dec 14, 2021

Conversation

MattTrim1
Copy link
Contributor

Overview

In the Custom Group creation screen, the default settings for collapsed display have caused discussion on whether the current defaults make sense.

Discussion on Gitlab here.

Before

'Collapse this set on initial display' selected.
'Collapse this set in Advanced Search' unselected.

image

After

'Collapse this set on initial display' unselected.
'Collapse this set in Advanced Search' selected.

image

Technical Details

N/A - fairly trivial change.

Comments

This is my first contribution to Core, I thought a simple change like this was a nice way to dip my toe into the water. I'm hoping to start contributing a bit more in future.

This was flagged in the 'community' CiviCRM Mattermost channel as needing community input here.

The Gitlab discussion so far has a higher number of agreements to the proposal than disagreements, but it could possibly be a good idea to await further discussion.

@civicrm-builder
Copy link

Can one of the admins verify this patch?

@civibot
Copy link

civibot bot commented Dec 13, 2021

(Standard links)

@civibot civibot bot added the master label Dec 13, 2021
@MattTrim1 MattTrim1 marked this pull request as ready for review December 13, 2021 23:48
@MattTrim1 MattTrim1 changed the title For custom group creation, flip the default display settings dev/core#2977 - For custom group creation, flip the default display settings Dec 14, 2021
@demeritcowboy
Copy link
Contributor

Thanks for the PR - yes it's probably a good one to get started. I don't think I have the permission to add you to the list that can run the tests but let's see what happens: Jenkins add to whitelist

@demeritcowboy
Copy link
Contributor

@MattTrim1 Can you also make a PR to add yourself to the contributor list? Just a PR that updates this file: https://github.com/civicrm/civicrm-core/blob/master/contributor-key.yml

@MattTrim1
Copy link
Contributor Author

Thanks, @demeritcowboy. I've created #22248.

@demeritcowboy demeritcowboy merged commit 5025be1 into civicrm:master Dec 14, 2021
@MattTrim1 MattTrim1 deleted the flip-default-display-custom-group-options branch December 14, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants