dev/core#2977 - For custom group creation, flip the default display settings #22244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In the Custom Group creation screen, the default settings for collapsed display have caused discussion on whether the current defaults make sense.
Discussion on Gitlab here.
Before
'Collapse this set on initial display' selected.
'Collapse this set in Advanced Search' unselected.
After
'Collapse this set on initial display' unselected.
'Collapse this set in Advanced Search' selected.
Technical Details
N/A - fairly trivial change.
Comments
This is my first contribution to Core, I thought a simple change like this was a nice way to dip my toe into the water. I'm hoping to start contributing a bit more in future.
This was flagged in the 'community' CiviCRM Mattermost channel as needing community input here.
The Gitlab discussion so far has a higher number of agreements to the proposal than disagreements, but it could possibly be a good idea to await further discussion.