fixes report#85 - Don't crash Contact Logging Detail report when viewing a contribution

[MegaphoneJon]

https://lab.civicrm.org/dev/report/-/issues/85

Attempting to view the details of a contribution on the Change Log tab fails if the contact was updated in the same database connection.

Steps to replicate

• Turn on advanced logging.
• Record a donation through a contribution page for either a) a new contact, b) an existing contact, but adding/changing their name.
• Go to that contact's change log, and try to view the details of the most recent change (by clicking Update next to the change).

Before

DB Error: Syntax Error.

After

You see the changes.

This regression comes from PR 19504. Previously, not every DAO had a _labelField property - so CRM_Logging_ReportDetail::convertForeignKeyValuesToLabels() checking if the property existed was basically the same as checking if it was defined. Now it will always exist (in CRM_Core_DAO) but not always be defined. So we change the conditional to reflect that.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

So oddly this was the test error I got locally before the patch, but then for me it passed after the patch. So hmm...

CRM_Report_Form_Contact_LoggingDetailTest::testLabelFieldIsntRequired
Undefined variable $original

/home/jenkins/bknix-dfl/build/core-22242-3uj0o/web/sites/all/modules/civicrm/CRM/Logging/Differ.php:217
/home/jenkins/bknix-dfl/build/core-22242-3uj0o/web/sites/all/modules/civicrm/CRM/Logging/Differ.php:442

Then there's also another error which might just be fallout from the first one because logging might still be enabled from before:

api_v3_LoggingTest::testEnableDisableLogging
Failed asserting that 0 matches expected 1.

/home/jenkins/bknix-dfl/build/core-22242-3uj0o/web/sites/all/modules/civicrm/tests/phpunit/api/v3/LoggingTest.php:63

[demeritcowboy]

This one is being stubborn:

api_v3_LoggingTest::testEnableDisableLogging
Failed asserting that 0 matches expected 1.

/home/jenkins/bknix-dfl/build/core-22242-3uj0o/web/sites/all/modules/civicrm/tests/phpunit/api/v3/LoggingTest.php:63

I don't offhand know what the problem is, but my guess is something to do with the fact that disabling logging by itself doesn't delete the log tables (which is correct). So if civi::settings gets cleared between tests, that logging_unique_XX setting doesn't get reset even when logging is re-enabled since it doesn't recreate the log tables?

[demeritcowboy]

Thanks @MegaphoneJon