Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afform - Set date-range defaults #22234

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Dec 9, 2021

Overview

Ensures datepickers can select more than the current year (start and end date years were defaulting to 0)
Fixes dev/report#84

Before

DatePicker defaults to only the current year

After

Datepicker defaults to +-10 years

@civibot
Copy link

civibot bot commented Dec 9, 2021

(Standard links)

@civibot civibot bot added the master label Dec 9, 2021
@colemanw colemanw force-pushed the afformDateRange branch 2 times, most recently from f01f0c3 to 2eea128 Compare December 9, 2021 18:39
return false;
}
return true;
return lowerFormat.indexOf('d') >= 0;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit is just cleanup suggested by my IDE.

Ensures datepickers can select more than the current year (start and end date years were defaulting to 0)
Fixes dev/report#84
@mlutfy
Copy link
Member

mlutfy commented Dec 9, 2021

r-run works:

image

and code review makes sense.

@colemanw Thank you!

@mlutfy mlutfy merged commit 7865c26 into civicrm:master Dec 9, 2021
@colemanw colemanw deleted the afformDateRange branch December 10, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants