[NFC] Update System Uft8mb4 check to handle for the fact that MySQL8 …

[seamuslee001]

…outputs utf8mb3 when the charset has been set to utf8 as utf8mb3 is the underlyling charset for utf8

Overview

This fixes the following test failure api_v3_SystemTest::testSystemUTFMB8Conversion Failed asserting that 'CREATE TABLE civicrm_contact (\n....) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=utf8mb3 COLLATE=utf8_unicode_ci ROW_FORMAT=DYNAMIC' ends with "DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci ROW_FORMAT=DYNAMIC".

Before

api_v3_SystemTest::testSystemUTFMB8Conversion fails on MySQL8

After

api_v3_SystemTest::testSystemUTFMB8Conversion passed on MySQL8

Technical Details

As per https://dev.mysql.com/doc/refman/8.0/en/charset-unicode-utf8mb3.html mysql 8 onwards is now outputting utf8mb3 when it used to output utf8 as the default charsets for tables

Comments

ping @eileenmcnaughton @totten @demeritcowboy

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

I thought I remembered seeing a utility function you had added to check if db is mysql8 since something else had come up before but can't find it. But whatever.

[demeritcowboy]

This is probably what I was thinking of:

civicrm-core/tests/phpunit/CRM/Logging/SchemaTest.php

Line 451 in aed6c7f

protected function isMySQL8(): bool {

So I'm not crazy, at least not about this...