Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 Export - Fix logic for exporting pseudoconstant syntax #22201

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Dec 1, 2021

Overview

Fixes an edge-case issue with exporting records with option-value type fields.

Before

Logic was trying to guess which was right based on how the option keys look.

After

Logic actually checks where the options come from to get it right.

Comments

The bulk of this diff is just indentation change, adding an IF around some code.

@civibot
Copy link

civibot bot commented Dec 1, 2021

(Standard links)

@civibot civibot bot added the master label Dec 1, 2021
@totten
Copy link
Member

totten commented Dec 2, 2021

@colemanw Check code style

@colemanw colemanw force-pushed the exportPseudoconstantFix branch from a1e683f to f272efd Compare December 3, 2021 03:39
@colemanw
Copy link
Member Author

colemanw commented Dec 3, 2021

@totten fixed

@colemanw colemanw force-pushed the exportPseudoconstantFix branch from f272efd to 21ecd39 Compare December 5, 2021 03:07
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@colemanw colemanw changed the base branch from master to 5.45 December 7, 2021 23:00
@civibot civibot bot added 5.45 and removed master labels Dec 7, 2021
@colemanw
Copy link
Member Author

colemanw commented Dec 7, 2021

I'd prefer this get merged into 5.45 since it fixes new functionality in that release.

@seamuslee001 seamuslee001 merged commit bbc751f into civicrm:5.45 Dec 8, 2021
@seamuslee001
Copy link
Contributor

Code seemed fine to me and will test with the RC all together and adds some extra Unit tests

@seamuslee001 seamuslee001 deleted the exportPseudoconstantFix branch December 8, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants