Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Smarty variables] Fix overzealous escaping with smarty default escaping #22194

Merged
merged 1 commit into from
Dec 9, 2021
Merged

[Smarty variables] Fix overzealous escaping with smarty default escaping #22194

merged 1 commit into from
Dec 9, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Nov 30, 2021 •
edited
Loading

Overview

Fix overzealous escaping with smarty default escaping

( if you add define('CIVICRM_SMARTY_DEFAULT_ESCAPE', TRUE); to civicrm.settings.php & then clear templates_c it borks )

Before

image

After

image

Technical Details

Comments

@civibot civibot bot added the master label Nov 30, 2021
@civibot
Copy link

civibot bot commented Nov 30, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton eileenmcnaughton changed the title Fix overzealous escaping with smarty default escaping [Smarty variables] Fix overzealous escaping with smarty default escaping Dec 1, 2021
@eileenmcnaughton
Copy link
Contributor Author

test this please

1 similar comment
@yashodha
Copy link
Contributor

yashodha commented Dec 1, 2021

test this please

@yashodha
Copy link
Contributor

yashodha commented Dec 2, 2021

test this please

@demeritcowboy
Copy link
Contributor

jenkins retest this please

@demeritcowboy demeritcowboy merged commit 59b516c into civicrm:master Dec 9, 2021
@eileenmcnaughton eileenmcnaughton deleted the smarty19 branch December 9, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @yashodha @demeritcowboy