-
-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Smarty variables] - remove isset #22185
Conversation
(Standard links)
|
It used to be here but then seems to have magically disappeared after this:
|
@demeritcowboy I think I can remove that bit-of-if then |
0768d7d
to
b419424
Compare
@demeritcowboy updated |
Silly question - what page is this tpl used on? |
@demeritcowboy I think a basic find activities hits this - try adding this to civicrm.settings.php
and deleting templates_c (note anything you hit right now when you do that likely has an open PR right now) |
I tried Find Activities, also advanced search displayed as activities, all the case-y screens, and the contact activity tab. I put some markup in the tpl and it never showed up. |
@demeritcowboy I did hit it - I thought it was in manage case or something - did you try with the define set? |
With the define, even clearing templates_c, I don't hit this. I'm not sure this file is used anymore, e.g. just grepping
|
hmm - I could swear I hit it - although my head is spinning - I'm down to just one isset (and 20 open PRs) |
test this please |
1 similar comment
test this please |
unrelated fail |
Overview
[Smarty variables - remove isset
Before
fatal with smarty escape on output
After
works
Technical Details
@demeritcowboy is this ever set? I couldn't find it...
Comments