Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Smarty variables] - remove isset #22185

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[Smarty variables - remove isset

Before

fatal with smarty escape on output

After

works

Technical Details

@demeritcowboy is this ever set? I couldn't find it...

Comments

@civibot
Copy link

civibot bot commented Nov 30, 2021

(Standard links)

@civibot civibot bot added the master label Nov 30, 2021
@demeritcowboy
Copy link
Contributor

It used to be here but then seems to have magically disappeared after this:

<dl><dd>{include file="CRM/Activity/Selector/Activity.tpl" caseview=1}</dd></dl>

@eileenmcnaughton
Copy link
Contributor Author

@demeritcowboy I think I can remove that bit-of-if then

@eileenmcnaughton
Copy link
Contributor Author

@demeritcowboy updated

@demeritcowboy
Copy link
Contributor

Silly question - what page is this tpl used on?

@eileenmcnaughton
Copy link
Contributor Author

@demeritcowboy I think a basic find activities hits this - try adding this to civicrm.settings.php

define('CIVICRM_SMARTY_DEFAULT_ESCAPE', TRUE);

and deleting templates_c

(note anything you hit right now when you do that likely has an open PR right now)

@demeritcowboy
Copy link
Contributor

I tried Find Activities, also advanced search displayed as activities, all the case-y screens, and the contact activity tab. I put some markup in the tpl and it never showed up.

@eileenmcnaughton
Copy link
Contributor Author

@demeritcowboy I did hit it - I thought it was in manage case or something - did you try with the define set?

@demeritcowboy
Copy link
Contributor

With the define, even clearing templates_c, I don't hit this. I'm not sure this file is used anymore, e.g. just grepping

{*include file="CRM/Activity/Selector/Activity.tpl"*}

@eileenmcnaughton
Copy link
Contributor Author

hmm - I could swear I hit it - although my head is spinning - I'm down to just one isset (and 20 open PRs)

@eileenmcnaughton
Copy link
Contributor Author

test this please

1 similar comment
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton
Copy link
Contributor Author

unrelated fail

@eileenmcnaughton eileenmcnaughton merged commit 8416f5c into civicrm:master Dec 1, 2021
@eileenmcnaughton eileenmcnaughton deleted the smarty11 branch December 1, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants