Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchKit - Fix regression for pseudoconstant selection #22170

Merged
merged 1 commit into from
Nov 30, 2021
Merged

SearchKit - Fix regression for pseudoconstant selection #22170

merged 1 commit into from
Nov 30, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Nov 30, 2021 •
edited
Loading

Overview

Fixes regression described in https://lab.civicrm.org/dev/report/-/issues/83 which was caused by #22130

Before

Options incorrectly matched, causing no results from search:
image

After

Fixed

@civibot
Copy link

civibot bot commented Nov 30, 2021

(Standard links)

@civibot civibot bot added the 5.44 label Nov 30, 2021
@colemanw
Copy link
Member Author

@demeritcowboy this is easy to test because it affects all option lists not just the one you noted in the issue. See screenshot above.

@demeritcowboy
Copy link
Contributor

Thanks @colemanw works for me.

@colemanw colemanw merged commit 0961f3f into civicrm:5.44 Nov 30, 2021
@colemanw colemanw deleted the fixSearchKitOptions branch November 30, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.44 merge on pass sig:regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @demeritcowboy