Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Smarty Variables] Remove isset from location type form #22167

Merged
merged 1 commit into from
Nov 30, 2021
Merged

[Smarty Variables] Remove isset from location type form #22167

merged 1 commit into from
Nov 30, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[Smarty Variables] Remove isset from location type form

Before

/civicrm/admin/locationType?reset=1 has isset checks in smarty which do not work with escaping by default

After

always assigned

Technical Details

I extracted getRows so I could override it

Comments

@civibot
Copy link

civibot bot commented Nov 30, 2021

(Standard links)

@civibot civibot bot added the master label Nov 30, 2021
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001 seamuslee001 merged commit 4b81d4e into civicrm:master Nov 30, 2021
@seamuslee001 seamuslee001 deleted the location_tpl branch November 30, 2021 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @seamuslee001 @colemanw