Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Allow searches of OptionValues, LocationTypes, CustomFields #22151

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

colemanw
Copy link
Member

Overview

This flips the switch on a few entities to be searchable in SearchKit, with an eye toward more UIs being built with it.

Before

SearchKit doesn't work for OptionValues, CustomFields or LocationTypes

After

It does

Technical Details

Marks the entities searchable, and adds view/edit links for OptionValues

@civibot
Copy link

civibot bot commented Nov 29, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

I'm fine with this - there is a meta issue that as we expose more admin config through the api / search kit we potentially make it easier for people to do bad things. I don't think changes that situation much - but something to keep thinking about

@eileenmcnaughton eileenmcnaughton merged commit 2031271 into civicrm:master Nov 29, 2021
@eileenmcnaughton eileenmcnaughton deleted the optionValueSearch branch November 29, 2021 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants