Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign cgCount in Case custom data form #22140

Merged
merged 1 commit into from
Nov 27, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Assign cgCount in Case custom data form

Before

isset used in template, test fails without it

After

assign the variable

Technical Details

Comments

@civibot
Copy link

civibot bot commented Nov 26, 2021

(Standard links)

@civibot civibot bot added the master label Nov 26, 2021
@colemanw
Copy link
Member

@eileenmcnaughton are we safe to assume that wherever else this variable gets assigned is later in the process so this won't clobber the value?

@demeritcowboy
Copy link
Contributor

It's a good question - cgCount is for custom groups that can have multiple instances right? Case custom fields don't do that (I think only Contacts). Some quick testing on the case custom field edit form suggests it never assigns cgCount for case custom fields.

@eileenmcnaughton
Copy link
Contributor Author

The other places that assign cgCount don't seem to intersect with this form at all

image

@colemanw
Copy link
Member

Ok. Looks safe.

@colemanw colemanw merged commit f294e7e into civicrm:master Nov 27, 2021
@eileenmcnaughton eileenmcnaughton deleted the cust_case branch November 27, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants