Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fields.tpl #22129

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Update Fields.tpl #22129

merged 1 commit into from
Nov 24, 2021

Conversation

kurund
Copy link
Contributor

@kurund kurund commented Nov 24, 2021

@civibot
Copy link

civibot bot commented Nov 24, 2021

(Standard links)

@civibot civibot bot added the master label Nov 24, 2021
@colemanw
Copy link
Member

Hey @kurund we can trade reviews on this - I have these which need looking at: https://github.com/civicrm/civicrm-core/pulls?q=is%3Aopen+is%3Apr+author%3Acolemanw+search+-is%3Adraft+

@kurund
Copy link
Contributor Author

kurund commented Nov 24, 2021

Not sure if I would get to all of them but can review few :)

@colemanw
Copy link
Member

I reviewed this code and can confirm it fixes the issue without introducing any potentially undefined smarty variables. It does reference a potentially undefined {$prefix} but that's a pre-existing issue that can be addressed at the form level per Eileen's work in this area.

@colemanw colemanw merged commit 9d78aab into civicrm:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants