Use getEntityNameForTable() instead of getClassForTable(), as this might yield ambiguous results

[jensschuppe]

Overview

Use CRM_Core_DAO_AllCoreTables::getEntityNameForTable() instead of CRM_Core_DAO_AllCoreTables::getBriefName(CRM_Core_DAO_AllCoreTables::getClassForTable()) constructs, as this might yield ambiguous results since entities can share a DAO class.

Before

The first result returned by array_search() lookups in CRM_Core_DAO_AllCoreTables::getBriefName() might not be the entity in question, because there can be multiple entities sharing a DAO class.

After

The correct entity is being returned.

Technical Details

See #21853 for why entities are now being indexed by brief name instead of class name.

Comments

This is toward work on virtual entities, followup to #21853

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[jensschuppe]

Pinging @colemanw.

[colemanw]

Yes, definitely +1 to this change.

[seamuslee001]

I think test Fail maybe related here

[colemanw]

@jensschuppe the test failure showed that we were not taking multilingual schema into account in our new function. I've pushed a fix to this PR.