SearchKit - Improve search listing UI #22114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using one searchDisplay with a hidden filter, which causes ajax reload when switching tabs, this creates 2 search displays which are always present but shown/hidden by the tabs.
|
(Standard links)
|
|
Retest this please |
|
Jenkins re test this please |
|
Retest this please |
|
@seamuslee001 this finally passed |
|
Looks good to me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A few improvements to the main SearchKit screen (the tabbed listing of Saved Searches)
Comments
Notice in the screenshot example above, the first packaged search has been overridden so it shows a modified date & a revert button. The 2nd is still in its pristine state so the revert button is not shown.