Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#2962) get contact id for the mailing along with display nam… #22096

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

yashodha
Copy link
Contributor

…e and email

Overview

One would expect contact id to be returned here as well in getContactInfo method in CRM/Mailing/Event/BAO/Queue.php along with display name and email.

Before

no contact id available.

After

contact id exposed

@civibot
Copy link

civibot bot commented Nov 18, 2021

(Standard links)

@civibot civibot bot added the master label Nov 18, 2021
@eileenmcnaughton
Copy link
Contributor

If we had a v4 api for that entity we could probably call it & delete that function from the looks

@totten
Copy link
Member

totten commented Dec 11, 2021

This change looks pretty safe. I did a quick r-run, and it looks as advertised.

## Before
$ cv ev 'return CRM_Mailing_Event_BAO_Queue::getContactInfo(1);'
[
    "admin@example.com",
    "admin@example.com"
]

## After
$ cv ev 'return CRM_Mailing_Event_BAO_Queue::getContactInfo(1);'
[
    "admin@example.com",
    "admin@example.com",
    "202"
]

@totten totten merged commit fa3c8ab into civicrm:master Dec 11, 2021
@yashodha
Copy link
Contributor Author

@totten Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants