APIv4 - Fix checkAccess for CiviCase or other entities with nonstandard class names

[colemanw]

Overview

Fixes https://lab.civicrm.org/dev/core/-/issues/2950

Before

APIv4 mistakenly thinks the lowercase entity name is 'civi_case' before applying permissions.

After

Correctly registers as 'case' and permissions are correctly looked up.

Technical Details

The use of self::getEntityName() instead of static::getEntityName() was causing the overridden Civi\Api4\CiviCase::getEntityName() to be overlooked.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[AsylumSeekersCentre]

I have tested this change on 5.43.2, and I can confirm that it resolves this issue for us: https://lab.civicrm.org/dev/core/-/issues/2950

[seamuslee001]

Merging based on review from @AsylumSeekersCentre

[highfalutin]

Thanks for your work on this @AsylumSeekersCentre and @colemanw, we ran into the same issue and are very happy to see it solved!