Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit with Form Builder when viewed on the front-end displays a CiviCRM breadcrumb trail which can duplicate the existing website breadcrumb trail #22087

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

agileware-justin
Copy link
Contributor

@agileware-justin agileware-justin commented Nov 16, 2021

SearchKit with Form Builder when viewed on the front-end displays a CiviCRM breadcrumb trail which can duplicate the existing website breadcrumb trail. Do not display breadcrumb on front-end pages

Before

Breadcrumb trail shown on front-end pages, on the website. Which can duplicate the existing website breadcrumb trail.

After

Breadcrumb trail NOT shown on front-end pages, on the website. Any existing website breadcrumb trail is shown.

Technical Details

Comments

Raised this as an issue in Gitlab, https://lab.civicrm.org/dev/report/-/issues/78

Agileware Ref: CIVICRM-1887

@civibot
Copy link

civibot bot commented Nov 16, 2021

(Standard links)

@civibot civibot bot added the master label Nov 16, 2021
@agileware-justin agileware-justin force-pushed the CIVICRM-1887 branch 3 times, most recently from a31417a to cfe2b29 Compare November 16, 2021 02:23
…d displays a CiviCRM breadcrumb trail which can duplicate the existing website breadcrumb trail. Do not display breadcrumb on front-end pages
@agileware-justin agileware-justin changed the title SearchKit, when viewed on the front-end displays a CiviCRM breadcrumb trail which can duplicate the existing website breadcrumb trail SearchKit with Form Builder when viewed on the front-end displays a CiviCRM breadcrumb trail which can duplicate the existing website breadcrumb trail Nov 16, 2021
@colemanw
Copy link
Member

This looks like the right fix code-wise. Needs r-run.

@colemanw
Copy link
Member

Retest this please

@colemanw
Copy link
Member

Ok, I tried the PR sandbox which uses Drupal7, which does not have a concept of "Front End" pages, and confirmed that the breadcrumb has not been affected by this PR.

@colemanw colemanw merged commit b0518de into civicrm:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants