Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove smarty isset in favour of always set #22084

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Remove smarty isset in favour of always set #22084

merged 1 commit into from
Nov 18, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove smarty isset in favour of always set

Before

checks if it is set

After

always set

Technical Details

I couldn't find anywhere it is set so commented in the code to that effect

Comments

@civibot
Copy link

civibot bot commented Nov 15, 2021

(Standard links)

@civibot civibot bot added the master label Nov 15, 2021
@seamuslee001
Copy link
Contributor

Test fail relates @eileenmcnaughton

@eileenmcnaughton eileenmcnaughton force-pushed the search branch 2 times, most recently from c943622 to 2b88ff7 Compare November 17, 2021 23:39
@colemanw
Copy link
Member

Looks great!

@colemanw colemanw merged commit afc3a25 into civicrm:master Nov 18, 2021
@colemanw colemanw deleted the search branch November 18, 2021 22:21
@christianwach christianwach mentioned this pull request Feb 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @seamuslee001 @colemanw