[REF] dev/drupal#169 Replace other usages of session_id with CRM_Core…

[seamuslee001]

…_Config::singleton()->userSystem->getSessionId

Overview

As per the ticket this replaces other places in the code that call for session_id with the newly added function

Before

session_id function used

After

UserSystem getSessionId function used

ping @demeritcowboy @MegaphoneJon

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

This seems technically fine but probably doesn't need to be in 5.44. As noted in the ticket the IDS one is only used for logging and the chart one is a broken feature (broken somewhere along with the changes for civicrm/civicrm-packages#267 and then further with buttonrama 14120ba), so I'd consider just removing the chartId stuff.

[seamuslee001]

@demeritcowboy this is now against master as well, I think we should still fix these points even tho the chart one may not work just for consistency sake

[seamuslee001]

thanks @demeritcowboy