Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Smarty variables] Ensure groupElementType is always set #22074

Merged
merged 2 commits into from
Nov 29, 2021
Merged

[Smarty variables] Ensure groupElementType is always set #22074

merged 2 commits into from
Nov 29, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Ensure groupElementType is always set

Before

Not always set

After

Set...

Technical Details

Removes as isset from smarty

Comments

@civibot
Copy link

civibot bot commented Nov 14, 2021

(Standard links)

@civibot civibot bot added the master label Nov 14, 2021
@seamuslee001
Copy link
Contributor

test failures relates here @eileenmcnaughton

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 interestingly it fails locally on #22075 - not sure why my local seems less tolerant than the remove on the isset

@eileenmcnaughton
Copy link
Contributor Author

Oh - of course - my local must have the define set - but for the remote this isn't merged yet #22070

@eileenmcnaughton
Copy link
Contributor Author

now failing on #22076

@eileenmcnaughton eileenmcnaughton force-pushed the tags branch 7 times, most recently from bbf73a8 to 44f5052 Compare November 20, 2021 01:59
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton eileenmcnaughton force-pushed the tags branch 8 times, most recently from 7c52046 to de51640 Compare November 29, 2021 05:55
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton eileenmcnaughton changed the title Ensure groupElementType is always set [Smarty variables] Ensure groupElementType is always set Nov 29, 2021
@colemanw colemanw merged commit 55144d4 into civicrm:master Nov 29, 2021
@colemanw colemanw deleted the tags branch November 29, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @seamuslee001 @colemanw