Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not check is context is set, should always be #22069

Merged
merged 1 commit into from
Nov 13, 2021
Merged

Do not check is context is set, should always be #22069

merged 1 commit into from
Nov 13, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Do not check is context is set, should always be

Before

We've added $context to 'always assigned - but still have isset checks

After

no longer checking....

Technical Details

Comments

@civibot
Copy link

civibot bot commented Nov 13, 2021

(Standard links)

@civibot civibot bot added the master label Nov 13, 2021
@seamuslee001
Copy link
Contributor

Looks fine to me and tests are happy on php8 so that is a good sign merging

@seamuslee001 seamuslee001 merged commit aa959f0 into civicrm:master Nov 13, 2021
@seamuslee001 seamuslee001 deleted the context branch November 13, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001